Unify web api exception return value specification to json. #7888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
approved these changes
Dec 30, 2024
CalvinKirs
reviewed
Dec 30, 2024
...b-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
Show resolved
Hide resolved
Contributor
|
Any update on this one, by chance? It looks like @CalvinKirs approved, but the patch hasn't yet been merged. Not sure if it needs extra attention from someone like @rlwhitcomb or @sboorlagadda. I note a few failed tests, but sadly the logs are expired and I can't pull any additional detail. |
Member
|
Sorry for the delayed response... I just wanted to get more people involved in the review. Overall, I have no objections to these changes. |
JinwooHwang
pushed a commit
that referenced
this pull request
Sep 3, 2025
(cherry picked from commit c1ba95c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?